Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b0 bugfix #59

Merged
merged 3 commits into from
Jan 9, 2022
Merged

b0 bugfix #59

merged 3 commits into from
Jan 9, 2022

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Jan 9, 2022

There was an extra alpha in b^0 inside a function in the Tmunu calculation (used for calculating geometric sources) that was then being used in the actual expression for Tmunu outside of that function. With this extra factor removed, the torus looks much better (here at 2000M):

image

@brryan brryan requested a review from jdolence January 9, 2022 02:29
@brryan brryan self-assigned this Jan 9, 2022
@brryan
Copy link
Collaborator Author

brryan commented Jan 9, 2022

@jdolence if you agree with this change, I think we should merge this in to your jdolence/torus and then merge jdolence/torus into main without delay.

@jdolence jdolence merged commit 142a70e into jdolence/torus Jan 9, 2022
@Yurlungur Yurlungur deleted the brryan/b0_bugfix branch October 25, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants