Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow the inner boundary to be outside the horizon in the torus #78

Merged
merged 3 commits into from
Feb 15, 2022
Merged

allow the inner boundary to be outside the horizon in the torus #78

merged 3 commits into from
Feb 15, 2022

Conversation

jdolence
Copy link
Member

No description provided.

brryan
brryan approved these changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@brryan brryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If feeling ambitious, maybe a PARTHENON_REQUIRE(nx1_target >= nx1, "duh"); otherwise this could produce weird behavior

@jdolence jdolence changed the title WIP: allow the inner boundary to be outside the horizon in the torus allow the inner boundary to be outside the horizon in the torus Feb 15, 2022
@jdolence jdolence merged commit 0894e9b into main Feb 15, 2022
@Yurlungur Yurlungur deleted the jdolence/cutout_torus branch October 25, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@brryan brryan brryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdolence @Yurlungur @brryan