-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pytest on latest jax version #126
Conversation
9224606
to
1dcdcc7
Compare
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 44 44
Lines 3160 3160
=======================================
Hits 2884 2884
Misses 276 276
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@@ -49,3 +47,29 @@ jobs: | |||
flags: unittests | |||
name: codecov-umbrella | |||
verbose: true | |||
|
|||
pytest-latest-jax: | |||
# The type of runner that the job will run on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a bit more maintainable to put this part in a separate file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and quite timely considering that we already have problems with the most recent jax. Consider the comment on splitting files as an optional suggestion rather than a requirement for merge approval.
1dcdcc7
to
ea3ba34
Compare
This involves some code duplication in
pytest.yml
, but it gets the job done and doesn't require me (or later maintainers) to learn much about github workflow syntax.Closes #80.