Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pytest on latest jax version #126

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Conversation

Michael-T-McCann
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann commented Dec 9, 2021

This involves some code duplication in pytest.yml, but it gets the job done and doesn't require me (or later maintainers) to learn much about github workflow syntax.

Closes #80.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #126 (1dcdcc7) into main (e6c0b7c) will not change coverage.
The diff coverage is n/a.

❗ Current head 1dcdcc7 differs from pull request most recent head ea3ba34. Consider uploading reports for the commit ea3ba34 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files          44       44           
  Lines        3160     3160           
=======================================
  Hits         2884     2884           
  Misses        276      276           
Flag Coverage Δ
unittests 91.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c0b7c...ea3ba34. Read the comment docs.

@@ -49,3 +47,29 @@ jobs:
flags: unittests
name: codecov-umbrella
verbose: true

pytest-latest-jax:
# The type of runner that the job will run on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a bit more maintainable to put this part in a separate file?

Copy link
Collaborator

@bwohlberg bwohlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and quite timely considering that we already have problems with the most recent jax. Consider the comment on splitting files as an optional suggestion rather than a requirement for merge approval.

@bwohlberg bwohlberg added the developer Developer environment: issues related to CI, git, etc. label Dec 11, 2021
@Michael-T-McCann Michael-T-McCann enabled auto-merge (squash) December 13, 2021 18:05
@Michael-T-McCann Michael-T-McCann merged commit f262b6c into main Dec 13, 2021
@bwohlberg bwohlberg deleted the mike/latest_jax_pytest branch December 17, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Developer environment: issues related to CI, git, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tests run on the latest version of jax
2 participants