Replaced gpu<->cpu copies with host_callback in minimize.

[FernandoDavis]

Added the host_callback functionality using a lambda expression for the minimizer function.

• Return value of minimizer function is a non Jax-type object. To fix incompatibility with hcb, I only extracted the x value from the response object.
• This meant a change in tests was needed from out.x to just out.
• Did not find a suitable workaround to let me keep the response object while also allowing the hcb to work. Missing data from this new format is a success boolean to check if minimize worked, a message that explains if it did not, and some other attributes listed: fun, jax, hess, etc.

Closes #204

[FernandoDavis]

I'll check why the pytest is failing now in a few.

[codecov]

Codecov Report

Merging #253 (d6e0d30) into main (353a51d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   93.93%   93.95%   +0.02%     
==========================================
  Files          58       58              
  Lines        3495     3493       -2     
==========================================
- Hits         3283     3282       -1     
+ Misses        212      211       -1     

Flag	Coverage Δ
unittests	93.95% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
scico/solver.py	99.25% <100.00%> (+0.72%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[bwohlberg]

Ready for review?

[FernandoDavis]

Yes! I'll be available if anything comes up.

[FernandoDavis]

Yes! I'll be available if anything comes up.

…

________________________________ From: Brendt Wohlberg ***@***.***> Sent: Tuesday, September 6, 2022 10:59:23 AM To: lanl/scico ***@***.***> Cc: FERNANDO DAVIS RIVERA ***@***.***>; Author ***@***.***> Subject: Re: [lanl/scico] Replaced gpu<->cpu copies with host_callback in minimize. (PR #253) Ready for review? — Reply to this email directly, view it on GitHub<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flanl%2Fscico%2Fpull%2F253%23issuecomment-1238272628&data=05%7C01%7Cfernando.davis%40upr.edu%7Cc770bc4ca27c4b5f236408da901862c7%7C0dfa5dc0036f461599e494af822f2b84%7C0%7C0%7C637980731652842523%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vty94VyrSw8sv%2BRDGmD%2B0hqhgP%2F0opzktmfxmQqAqWw%3D&reserved=0>, or unsubscribe<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH4ZQ5KQJGEQQXKV2ANA4JTV45L4XANCNFSM5Q5JCNSA&data=05%7C01%7Cfernando.davis%40upr.edu%7Cc770bc4ca27c4b5f236408da901862c7%7C0dfa5dc0036f461599e494af822f2b84%7C0%7C0%7C637980731652842523%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dPa1oEJ1FG2eOPKyzW5WLJnmbHVV16ZltSOAUWGpiew%3D&reserved=0>. You are receiving this because you authored the thread.Message ID: ***@***.***>