Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean up and packaging fix #254

Merged
merged 8 commits into from
Mar 21, 2022
Merged

Minor clean up and packaging fix #254

merged 8 commits into from
Mar 21, 2022

Conversation

bwohlberg
Copy link
Collaborator

Minor clean up and packaging fix.

@bwohlberg bwohlberg added the developer Developer environment: issues related to CI, git, etc. label Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #254 (11857de) into main (e6e5776) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   93.71%   93.69%   -0.02%     
==========================================
  Files          49       49              
  Lines        3517     3507      -10     
==========================================
- Hits         3296     3286      -10     
  Misses        221      221              
Flag Coverage Δ
unittests 93.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/blockarray.py 91.18% <ø> (-0.03%) ⬇️
scico/diagnostics.py 88.05% <ø> (-0.18%) ⬇️
scico/functional/_functional.py 88.33% <ø> (ø)
scico/linop/_convolve.py 86.31% <ø> (-0.15%) ⬇️
scico/linop/_dft.py 100.00% <ø> (ø)
scico/linop/_linop.py 97.95% <ø> (-0.03%) ⬇️
scico/linop/_matrix.py 95.86% <ø> (-0.04%) ⬇️
scico/linop/optics.py 95.68% <ø> (-0.04%) ⬇️
scico/loss.py 93.06% <ø> (ø)
scico/metric.py 100.00% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e5776...11857de. Read the comment docs.

Copy link
Contributor

@FernandoDavis FernandoDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scico/loss.py Outdated Show resolved Hide resolved
scico/linop/_dft.py Show resolved Hide resolved
@bwohlberg bwohlberg merged commit 9ddbcd0 into main Mar 21, 2022
@bwohlberg bwohlberg deleted the brendt/manifest branch March 21, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Developer environment: issues related to CI, git, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants