Update and fix conda environment construction script #262
Conversation
bwohlberg
commented
Mar 23, 2022
bwohlberg
commented
- Remove options for installation with GPU support
- Remove requirement that script be run from repo root directory
- Updates to restore functionality broken by recent changes in the repo
bwohlberg
added
the
developer
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 93.61% 93.61%
=======================================
Files 49 49
Lines 3541 3541
=======================================
Hits 3315 3315
Misses 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| echo "Activate the conda environment with the command" | ||
| echo " conda activate $ENVNM" | ||
| echo "The environment can be deactivated with the command" | ||
| echo " conda deactivate" | ||
| echo | ||
| echo "Jax installed without GPU support. To avoid warning messages," |
There was a problem hiding this comment.
This means if GPU support is required then you should not use this script?
There was a problem hiding this comment.
No, it means that manual action is required after use of the script. I had assumed that this was implied by the following sentence "To include GPU support ...", but perhaps it's not as clear as I had thought?
There was a problem hiding this comment.
It was not clear to me. Let's make it more clear.
Also in the .rst file we could make it something like To include GPU support, follow the jax installation instructions after running the installation script.
