Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify FiniteDifference linop #296

Merged
merged 4 commits into from
May 16, 2022
Merged

Modify FiniteDifference linop #296

merged 4 commits into from
May 16, 2022

Conversation

bwohlberg
Copy link
Collaborator

Modify the FiniteDifference linop, changing the interface and adding support for more useful boundary handling options.

@bwohlberg bwohlberg added the improvement Improvement of existing code, including addressing of omissions or inconsistencies label May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #296 (0566b6d) into main (a3569a1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
+ Coverage   94.21%   94.30%   +0.09%     
==========================================
  Files          53       53              
  Lines        3303     3321      +18     
==========================================
+ Hits         3112     3132      +20     
+ Misses        191      189       -2     
Flag Coverage Δ
unittests 94.30% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/__init__.py 100.00% <100.00%> (ø)
scico/linop/_diff.py 98.30% <100.00%> (+5.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3569a1...0566b6d. Read the comment docs.

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice solution.

@bwohlberg bwohlberg merged commit 9d1fa8e into main May 16, 2022
@bwohlberg bwohlberg deleted the brendt/diff branch May 16, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants