Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ensure_on_device function #463

Merged
merged 18 commits into from
Nov 2, 2023
Merged

Conversation

bwohlberg
Copy link
Collaborator

Remove ensure_on_device function. Resolves #451.

@bwohlberg bwohlberg added the improvement Improvement of existing code, including addressing of omissions or inconsistencies label Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #463 (a5fb2fd) into main (d0e6c4c) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   94.59%   94.56%   -0.03%     
==========================================
  Files          87       87              
  Lines        5523     5495      -28     
==========================================
- Hits         5224     5196      -28     
  Misses        299      299              
Flag Coverage Δ
unittests 94.56% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scico/linop/_convolve.py 85.56% <100.00%> (-0.76%) ⬇️
scico/linop/_diag.py 97.62% <100.00%> (ø)
scico/linop/_matrix.py 95.97% <100.00%> (ø)
scico/linop/abel.py 98.21% <100.00%> (ø)
scico/linop/optics.py 99.19% <100.00%> (-0.01%) ⬇️
scico/linop/radon_svmbir.py 82.20% <100.00%> (ø)
scico/loss.py 94.83% <100.00%> (-0.12%) ⬇️
scico/numpy/util.py 97.47% <ø> (-0.28%) ⬇️
scico/optimize/_admm.py 95.96% <100.00%> (-0.04%) ⬇️
scico/optimize/_admmaux.py 96.77% <100.00%> (-0.03%) ⬇️
... and 4 more

@bwohlberg bwohlberg merged commit bcb1eab into main Nov 2, 2023
18 of 19 checks passed
@bwohlberg bwohlberg deleted the brendt/rm-ensure-on-device branch November 2, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reevaluate need for ensure_on_device function
2 participants