Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the SCICO x-ray projector #473

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Update the SCICO x-ray projector #473

merged 10 commits into from
Nov 30, 2023

Conversation

Michael-T-McCann
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann commented Nov 28, 2023 •
edited
Loading

Reimplement the X-ray projector to avoid aliasing artifacts. This projector is on par with ASTRA in terms of speed on the GPU.

@Michael-T-McCann Michael-T-McCann mentioned this pull request Nov 28, 2023
Merged
Michael-T-McCann
Michael-T-McCann commented Nov 28, 2023
View reviewed changes
data Outdated Show resolved Hide resolved
@Michael-T-McCann Michael-T-McCann marked this pull request as ready for review November 28, 2023 23:27
bwohlberg
bwohlberg requested changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@bwohlberg bwohlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only minor comments/suggestions other than rebuilding two notebooks and fixing the test failure.

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61f1c93) 94.57% compared to head (6f15e1a) 94.59%.

❗ Current head 6f15e1a differs from pull request most recent head 02b311d. Consider uploading reports for the commit 02b311d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   94.57%   94.59%   +0.01%     
==========================================
  Files          90       90              
  Lines        5584     5597      +13     
==========================================
+ Hits         5281     5294      +13     
  Misses        303      303
Flag Coverage Δ
unittests 94.59% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Michael-T-McCann Michael-T-McCann merged commit 917185c into main Nov 30, 2023
18 checks passed
@Michael-T-McCann Michael-T-McCann deleted the mike/xray_v3 branch November 30, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwohlberg bwohlberg Awaiting requested review from bwohlberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael-T-McCann @bwohlberg