Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #535 #541

Merged
merged 12 commits into from
Jul 24, 2024
Merged

Resolve #535 #541

merged 12 commits into from
Jul 24, 2024

Conversation

crstngc
Copy link
Contributor

@crstngc crstngc commented Jul 10, 2024

Consistently use jax-based random generation throughout Flax examples tests.

@bwohlberg bwohlberg assigned bwohlberg and unassigned bwohlberg Jul 10, 2024
@bwohlberg bwohlberg self-requested a review July 10, 2024 23:56
@bwohlberg bwohlberg added bug Something isn't working developer Developer environment: issues related to CI, git, etc. labels Jul 10, 2024
@bwohlberg bwohlberg linked an issue Jul 12, 2024 that may be closed by this pull request
@bwohlberg bwohlberg changed the title Change np random generation to jax np Resolve #535 Jul 15, 2024
bwohlberg and others added 7 commits July 19, 2024 11:23
* Add type annotation

* Remove jax distributed data generation option

* Remove jax distributed data generation option

* Clean up

* Clean up

* Extend docs

* Add additional test for exception state

* Tracer conversion error fix from Cristina

* Omitted import

* Clean up

* Consistent phrasing

* Clean up some f-strings

* Add missing ray init

* Set dtype

* Fix indentation error

* Update module docstring

* Experimental solution to ray/jax failure

* Bug fix

* Improve docstring

* Implement hack to resolve jax/ray conflict

* Debug attempt

* New solution attempt

* Debug attempt

* Return to earlier approach

* Extend comment

* Clean up and improve function logic

* Address some problems

* Clean up

* Rename function for consistency with related functions

* Bug fix

* Clean up

* Bug fix

* Address pylint complaint

* Revert unworkable structure
@bwohlberg bwohlberg merged commit 0dff98d into main Jul 24, 2024
18 checks passed
@bwohlberg bwohlberg deleted the cristina/issue535 branch July 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working developer Developer environment: issues related to CI, git, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure in scico.jax with latest jax version 0.4.29
3 participants