Improve docs for 3D astra X-ray transform #544
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 94.67% 92.23% -2.44%
==========================================
Files 91 91
Lines 5707 5910 +203
==========================================
+ Hits 5403 5451 +48
- Misses 304 459 +155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| The voxels sides have unit length (in arbitrary units), which defines | ||
| the scale for all other dimensions in the source-volume-detector | ||
| configuration. Geometry axes `x`, `y`, and `z` correspond to volume | ||
| array axes 0, 1, and 2 respectively. The projected array axes 0, 1, |
There was a problem hiding this comment.
Consider remarking that this is different from astra's default interface, were I think x y z corresponds to 2 1 0.
There was a problem hiding this comment.
Good catch - fixed.
scico/linop/xray/astra.py
Outdated
| detector (i.e. in the direction of :math:`\mb{d}` in the figure.) In | ||
| practice, since the volume-detector distance does not have a | ||
| geometric effect for a parallel-beam configuration, :math:`\mb{d}` | ||
| may be set to the zero vector. Note that the view images must be |
There was a problem hiding this comment.
I think that d is useful for handling offsets in the center of rotation, i.e., situations where the center column of a projection view doesn't match up with the rotation axis. Put another way, because it's parallel ray, the component of d perpendicular to the detector doesn't matter, but the other components do matter.
There was a problem hiding this comment.
Phrasing modified to avoid over-simplification.
Improve docs for 3D
astraX-ray transform. Also move existingmatplotlibfigures from the submodule to the main repo.