Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This commit changes the semantics for lost movers, to avoid a segfault #121

Merged
merged 4 commits into from
Aug 27, 2020

Commits on Aug 26, 2020

  1. This commit changes the semantics for lost movers, to avoid a segfault

    Previously, if movers were lost the following would happen:
    
    1) The user would get a warning,
    2) The particle->i value would be shifted by move_p to be out of bounds
    3) The particle never makes it to boundary_p in order to processes it
    
    This either teleports the particle across the domain; or causes a
    segfault in the next timestep.
    
    This PR:
    
    1) Adds some notes to the user about how serious that warning is
    2) Undoes the shift, so instead of segfauliting the code now "holds" the
    particle at the cell boundary
    
    This breaks physics, but to a lesser extent than the previous
    teleporting of a particle. It's still crucial the user uses a correct
    value for nm
    
    To recreate these issues just use a deck where the intial nm is set to 1
    during define_species in the input deck
    rfbird committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    55b4052 View commit details
    Browse the repository at this point in the history
  2. tidy up include file

    rfbird committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    886261b View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. 3 Configuration menu
    Copy the full SHA
    5fee157 View commit details
    Browse the repository at this point in the history
  2. fix typo in cmake

    rfbird committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    541574e View commit details
    Browse the repository at this point in the history