Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global macro, this does the following things: #48

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Remove global macro, this does the following things: #48

merged 2 commits into from
Feb 28, 2019

Commits on Feb 6, 2019

  1. Remove global macro, this does the following things: 

    1. Removes an instance where we violate ansi alias rules by cast a char*
to a struct
2. Allows for file paths that contain the work global (previously
        defined macro messed them up)
3. Is somewhat cleaner

Largely this is an improvement, but comes with one down side:

The global type cannot be used before initialization, and initialization
must appear near the start of the file (previously only begin_globals
        had to be near the top)
    @rfbird
    rfbird committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    2df23e8 View commit details
    Browse the repository at this point in the history

  2. added comments to explain the semantics of the global macro

    @rfbird
    rfbird committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    b35a95c View commit details
    Browse the repository at this point in the history