Business Match API (closes #6) #7
Conversation
|
Upon a quick inspection, this looks solid. Would you mind adding a bullet at the bottom of |
|
You got it! |
|
Awesome! I haven't had a chance to actually pull this down and test it yet, but I'll do that shortly (most likely tomorrow). Would you mind making that |
|
Oh, another 2 small changes:
|
|
Version bumped! |
|
What's the |
yelpapi/yelpapi.py
Outdated
| NOTE: Mandatory parameters "name", "city", and "state" must be provided. | ||
| NOTE: Defaults to match_type using the "best" search method. Can be set to "lookup" for the top 10 results. | ||
| """ | ||
| if 'name' not in kwargs or not kwargs['name']: |
There was a problem hiding this comment.
A simpler way to do this check (and all other checks like it) is the following:
if not kwargs.get('name'):There are a few other places in this file where this pattern is found, and we should probably be using .get() for all of them.
CHANGES.md
Outdated
| ## 2.0.1 (2017-02-27) | ||
| * Remove reliance on `ez_setup.py`. | ||
| * Add `setup.cfg` to instruct the build process to build universal wheels. | ||
|
|
||
| ## 2.0 (2017-02-27) | ||
| * Implement the new Yelp Fusion API (aka Yelp v3 API). Note that yelpapi v1.4 is the last version to support the Yelp v2 API. [The Yelp v2 API is being deprecated, so all new developers should move to the new Fusion API ASAP.](https://engineeringblog.yelp.com/2017/02/recent-improvements-to-the-fusion-api.html) | ||
| * Use OAuth 2.0 for authentication. | ||
| * Implement new [Transaction Search API](https://www.yelp.com/developers/documentation/v3/transactions_search), [Reviews API](https://www.yelp.com/developers/documentation/v3/business_reviews), and [Autocomplete API](https://www.yelp.com/developers/documentation/v3/autocomplete). | ||
| * Use OAuth 2.0 for authentication. |
There was a problem hiding this comment.
I'd rather leave these indented since I was really just calling out specific changes related to the new Fusion API.
|
Ah, sorry! I was using GitHub's code review feature and didn't hit "submit". Do you see the comment on |
|
I've made the requested changes! |
|
Looks great to me! Merging. Thanks! |
This adds the Business Match API as requested in #6
I didn't pull request it as the match API didn't seem to be very effective for me in my testing, though it could have simply been the businesses I was trying to match on since the endpoint is beta.