Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend PATH= to Fix VTE assertion error. #438

Closed
wants to merge 1 commit into from

Conversation

KevinMoonglow
Copy link
Contributor

Prepends "PATH=" to the value returned by getenv("PATH"). This fixes an
assertion error in the VTE library that prevents the terminal from
spawning when using a custom command.

Fixes #435

Prepends "PATH=" to the value returned by getenv("PATH"). This fixes an
assertion error in the VTE library that prevents the terminal from
spawning when using a custom command.
@agb80
Copy link

agb80 commented Oct 20, 2020

Could you help us to review and merger @lanoxx?

@alanmcg
Copy link

alanmcg commented Oct 23, 2020

Tested this patch myself and it works well, thank you!

@lanoxx
Copy link
Owner

lanoxx commented Oct 25, 2020

To everyone who has commented here and in the duplicate issues. Thanks a lot for reporting this and thanks to @KevinMoonglow for providing the fix. I have just merged the pull request (with slightly modified commit message).

In order to get this into distributions I will need to make a new release of tilda and backport this fix. For Debian testing that should not be a big problem, but for Ubuntu 20.10 a stable release update will be necessary. If I find the time I will try to do that.

I anyone wants to help speed this up, then please check this link and use the SRU Bug template to file an SRU bug on Launchpad against the tilda package:
https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

@lanoxx lanoxx closed this Oct 25, 2020
@lanoxx
Copy link
Owner

lanoxx commented Oct 25, 2020

By the way, this issue was introduced by the following commit in VTE:
https://gitlab.gnome.org/GNOME/vte/-/commit/9697d30cead63dfba031d3547140668535395540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion error in libvte with a custom command
4 participants