Require 'gm' only when needed #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laoshu133
added a commit
that referenced
this pull request
Mar 5, 2014
Thank you very much to point out this issue, after a period of consideration, I decided to completely remove the `gm` module dependency . Thanks again.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now
gmmodule dependency is mandatory. As far as i know, installinggraphicsmagicunder Windows is not a trivial task. It requires external header files, or something like that. However, it should be an option to usepngsmithfor building sprites on those Windows machines, where it is impossible (or undesirable) to compilegraphicsmagiclibrary. On the other handgmis not needed every time - it's just mandatory when sprites for retina display are being processed.So I decided to require
gmon-demand. It gives a possibility to not use native C++ modules at all when retina images are not used.