New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加了标签页 V2 #37

Merged
merged 5 commits into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@bwangelme
Contributor

bwangelme commented Nov 28, 2017

上次的提交 #35 由于提交的时候自动去掉了行尾空格,导致了 header.html 文件内的if语句报错。

修复了这个错误后重新提一个PR。

这次我提交PR前先用 exampleSite 中的配置新建了一个空的博客验证了一下,可以正确生成内容,没有发现报错。

但是还请 @laozhu 也把add_tags_page分支上的代码拉到本地测一下,看有没有问题,确保没问题后再合并。

上次提了一个有问题的PR,确实有点抱歉。

@laozhu

This comment has been minimized.

Show comment
Hide comment
@laozhu

laozhu Nov 28, 2017

Owner

@bwangel23 辛苦了,我先拉下来看下。

Owner

laozhu commented Nov 28, 2017

@bwangel23 辛苦了,我先拉下来看下。

@laozhu laozhu merged commit fb64a31 into laozhu:master Nov 28, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

laozhu added a commit that referenced this pull request Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment