Darkmode for single file #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This closes #89. |
| @@ -1,10 +1,12 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <html data-theme="dark"> | |||
There was a problem hiding this comment.
@olibu is this necessary?
(and it is correct when OS theme is light? or would cause flickering on the other way?)
There was a problem hiding this comment.
Thinking about it, I'd say it's fine as it is.
There was a problem hiding this comment.
I verified it in dark and light mode to work without flickering. However, I set dark as the default. When testing I recognized that the dark flash is not as disturbing as the light flash.
Flickering stopped by separating the function into the theme.js
|
I transplanted your changes to a new branch (should be 1:1 and in your name). |
|
Merged in f03d403. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for dark mode in single file.
CSS is not modified any more. Themes are based on css conditions instead.
Darkmode is activated earlier now, because pages has flickered on when triggered in index.js