Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v18 packages should be used instead of v17 for sqlsrv (mssql) support in workspace and php-fpm #3466

Merged
merged 2 commits into from
Oct 19, 2023
Merged

v18 packages should be used instead of v17 for sqlsrv (mssql) support in workspace and php-fpm #3466

merged 2 commits into from
Oct 19, 2023

Conversation

oneCentral
Copy link
Contributor

@oneCentral oneCentral commented Oct 18, 2023 •
edited
Loading

Description

Motivation and Context

Building sqlsrv packages for workspace and php-fpm gave errors. This resolves the build errors

Types of Changes

  • Bug fix (non-breaking change which fixes an issue).
  • [] New feature (non-breaking change which adds functionality).
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Definition of Done Checklist:

  • I've read the Contribution Guide.
  • I've updated the documentation. (refer to this for how to do so).
  • I enjoyed my time contributing and making developer's life easier :)

@oneCentral oneCentral mentioned this pull request Oct 18, 2023
Open
@bestlong bestlong merged commit a41b322 into laradock:master Oct 19, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PHP Extension: sqlsrv / dblib (MSSQL) Microsoft SQL Server Functions Service: php-fpm Service: workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oneCentral @bestlong