Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dockerfiles #16

Merged
merged 4 commits into from
Apr 20, 2017
Merged

Cleanup dockerfiles #16

merged 4 commits into from
Apr 20, 2017

Conversation

winfried-van-loon
Copy link
Contributor

@winfried-van-loon winfried-van-loon commented Apr 19, 2017

Cleaning up the three Dockerfiles as discussed in #15.

I've tested the Dockerfile with all three versions like so:

docker build -t laradock/workspace:test -f Dockerfile . --no-cache --build-arg PHP_VERSION=56
docker build -t laradock/workspace:test -f Dockerfile . --no-cache --build-arg PHP_VERSION=70
docker build -t laradock/workspace:test -f Dockerfile . --no-cache --build-arg PHP_VERSION=71

Assuming that's correct, it can be merged and tagged.

@winfried-van-loon winfried-van-loon changed the title 8 cleanup dockerfiles Cleanup dockerfiles Apr 19, 2017
@Dayjo
Copy link

Dayjo commented Apr 20, 2017

Great job :) Hopefully this will get merged in and do the job!

@Mahmoudz Mahmoudz merged commit dbaa3fc into laradock:master Apr 20, 2017
@Mahmoudz
Copy link
Member

@winfried-van-loon That's really clean, thanks.

I would love to see those changes applied to the Laradock duplicated files, it will help us avoid missing support to some tools between different versions..

@winfried-van-loon
Copy link
Contributor Author

Agreed! Will first merge the new Workspace version into the laradock/laradock files to close the three or four open issues, will then start merging the dockerfiles together.

@winfried-van-loon winfried-van-loon deleted the 8-cleanup-dockerfiles branch April 20, 2017 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants