Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support better support collection of tokens #130

Merged
merged 11 commits into from
Feb 7, 2023
Merged

Support better support collection of tokens #130

merged 11 commits into from
Feb 7, 2023

Conversation

dwightwatson
Copy link
Collaborator

@dwightwatson dwightwatson commented Dec 18, 2022

  • Update dependencies
  • Remove spatie/enum dependency
  • Support single/array/collection of tokens
  • Handle value changes to Visibility enum

@msonowal
Copy link

ping @atymic

@dwightwatson
Copy link
Collaborator Author

I can merge this myself. However I am unable to test this as I don't currently have access to an Android project.

As noted in the other issue I'd love some people to test this and see if it works well. It drops some older PHP versions and introduces other changes.

@grEvenX
Copy link

grEvenX commented Feb 7, 2023

@dwightwatson Anything in particular you would want to test? I tested basic sending on Android with setting a title and body and it was sent fine 👍

@dwightwatson
Copy link
Collaborator Author

Nope - that's a great sanity check - thanks for that.

Maybe I'll merge this and tag as v3, that way it can live alongside v2 and both will support Laravel 10. Can iron out any issues as they arise but users can always fall back to v2 if they need.

@dwightwatson dwightwatson merged commit 9c0b33c into master Feb 7, 2023
@dwightwatson dwightwatson deleted the develop branch February 7, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants