Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed undefined quantity notice #1377

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Fixed undefined quantity notice #1377

merged 3 commits into from
Jun 15, 2022

Conversation

Lyrisbee
Copy link
Contributor

Fixed Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity when creating or swapping to a single metered price.

Related: #1254

Test:

cashier-stripe % ./vendor/bin/phpunit --filter test_swap_metered_price_to_different_price
PHPUnit 9.5.20

Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity
Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity
.Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity
Stripe Notice: Undefined property of Stripe\SubscriptionItem instance: quantity
.                                                                  2 / 2 (100%)

Time: 00:23.421, Memory: 28.00 MB

OK (2 tests, 24 assertions)

@taylorotwell taylorotwell merged commit 3bd37e8 into laravel:13.x Jun 15, 2022
@driesvints driesvints mentioned this pull request Jun 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lyrisbee @taylorotwell