-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Update installation.md #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation.md #2037
Conversation
I have added the missing extensions Dom and Zip to the list. I removed Tokenizer from the list, since it is enabled by default since PHP 4.3. The reason is because it is not an extension that you can install, but a compile-time option (that is enabled by default.)
👎 Every change here is wrong. |
The tokenizer IS still required, even if it may be enabled by default. As for the zip and dom extensions, they're simply not required for normal operation. |
Define normal operation. |
Tokenizer isn't an extension, but declared as one. Please fix that. |
It can be considered an extension, and composer treats it as one, because php represents it as one internally. |
You can reproduce this results by disabling the zip and dom extensions in your php.ini. $ php -v after enabling zip$ laravel new blog Problem 1 Application ready! Build something amazing. after enabling dom, everything builds fine. |
Install with |
Yes, the dom extension is needed for development. |
In terms of zip, it's not a requirement of laravel, just our installer. |
And, the installer is totally optional. I've never even needed to use it myself. |
The point is that it's incorrect to say that these extensions are required to run the application in production. |
I agree. I only followed the Installation from the Documentation page. But you won't succeed with the steps provided as is. Therefore I tried to help by updating the information. |
I have added the missing extensions Dom and Zip to the list.
I removed Tokenizer from the list, since it is enabled by default since PHP 4.3. The reason is because it is not an extension that you can install, but a compile-time option (that is enabled by default.)