[9.x] Removes section on local network sharing #8267
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the section on local sharing which was added to the documentation in #5677. The reasoning for this removal is that the feature doesn't exist in Laravel Valet. If a user follows the steps outlined in the documentation they'll always get back the default Laravel Valet 404 not found page.
I'm not sure why it was added to the documentation, but it seems at least @driesvints knows this feature doesn't exist. Given issue (laravel/valet#1093) was converted to a discussion for feature requests (laravel/valet#1143) instead of an issue.
There is also the following comment on another issue regarding local network access (laravel/valet#440 (comment)) where a user suggested a fix for getting local networking to work, but that requires changing internals for Laravel Valet.
As Laravel Valet is now there is no feature for local network sharing and the section can be removed.