Skip to content

Conversation

thinkverse
Copy link
Contributor

This PR removes the section on local sharing which was added to the documentation in #5677. The reasoning for this removal is that the feature doesn't exist in Laravel Valet. If a user follows the steps outlined in the documentation they'll always get back the default Laravel Valet 404 not found page.

I'm not sure why it was added to the documentation, but it seems at least @driesvints knows this feature doesn't exist. Given issue (laravel/valet#1093) was converted to a discussion for feature requests (laravel/valet#1143) instead of an issue.

There is also the following comment on another issue regarding local network access (laravel/valet#440 (comment)) where a user suggested a fix for getting local networking to work, but that requires changing internals for Laravel Valet.

As Laravel Valet is now there is no feature for local network sharing and the section can be removed.

@thinkverse
Copy link
Contributor Author

I made this PR a draft since laravel/valet#440 (comment) suggests a fix, and maybe it's good enough to have added? Then this PR wouldn't be needed.

@driesvints
Copy link
Member

I actually didn't know this feature existed. If that's broken somehow we need to look into it. Can you maybe send in a PR with that fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants