Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Use classes instead of IDs #9843

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[5.2] Use classes instead of IDs #9843

merged 1 commit into from
Aug 26, 2024

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Aug 26, 2024

Collection and helper function heading tags are currently broken for several older versions of the docs. This PR targets 5.2.

On server render, the heading tags all contain the same literal `id="collection-method" attribute; IDs are meant to be unique.

<h4 id="collection-method"><code>random()</code></h4>

When the JavaScript kicks in, the ID attribute is updated its corresponding <a name="..."> link, however the intended styling is then broken because it targets the id attribute, e.g., #collection-method { ... }.

  • Matches the later documentation versions
  • Gets the intended styling applied
  • Has no flash of styled / unstyled content

@taylorotwell taylorotwell merged commit 71ff046 into 5.2 Aug 26, 2024
@taylorotwell taylorotwell deleted the titles-5.2 branch August 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants