-
Notifications
You must be signed in to change notification settings - Fork 244
configurable "runAllTasks()" before watch #681
Conversation
Merge from laravel master
- group Elixir task by name - get a list of tasks and runners from each name - "tasks" is a list of globs which describe files that have to be watched - "runners" is a list of Tasks object which don't have globs, but an implicit "watch" logic (e.g. browserify + watchify) - if "runAllTasks()" before watch is enabled, for each "tasks" a gulp.watch is added - otherwise is disabled, for each "runners" is called "run()" method in order to start implicit watch logic and then for each "tasks" a gulp.watch is added
If this works , im going to be a very very happy person |
Can you help me understand better the issue that you're fixing here? So, if If that's so, can we fix it without a hack? Or maybe we can disable runAllTasks() entirely. That's how Elixir used to behave. |
@JeffreyWay yes, this is the problem. Or at least it seems that it happens in my last project (a lot of less and browserify compilation). I thought that adding a configuration in order to enable/disable |
@JeffreyWay anyway IMHO |
Okay, then I'm going to close this PR and remove that section. |
Actually, changed my mind. We're still triggering all tasks on |
@JeffreyWay ok, this should work fine, but there still are a couple of changes that can be done to make the code better. |
@JeffreyWay sadly your change doesn't work... I think that your approach is correct, but maybe the problem stands at a lower level. It seems that the "guilty" task is |
ideas on how to fix this? |
@JeffreyWay Check my temporary solution on #626 . It works every time. It may bring up some ideas. |
It was added a configuration to enable/disable
runAllTasks()
call before watch.This should help in some cases when
gulp watch
fails because of watchers start before all tasks are finished.It is like a hack, but it can be useful. I think that to fix all the issues related to
watch