This repository has been archived by the owner on Mar 31, 2020. It is now read-only.
Use gulp-concat-css to bubble up @import statements #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using gulp-concat-css instead of gulp-concat makes sure that
@import
statements are bubbled up to the top of the file. This is necessary because@import
statements that are not at the top of the file are ignored by the browser (as per the standard). The options{rebaseUrls: false, inlineImports: false}
makes this change non-breaking.I discovered this issue when I was concatenating vendor css files where one of them had an
@import
statement to import a Google Font:This ended up somewhere in the middle of the output file and was ignored by the browser.
gulp-concat-css
takes care of this problem.