I want to remove redundant method_exists() check

[hrant1020]

I want to remove the unnecessary code of method_exists($enumClass, 'tryFrom'). I belive the refactoring is correct. I'd like to know your opinion: could it potentially break something ?

PR link #51282

enum() method from \Illuminate\Http\Concerns\InteractsWithInput

As you see when $enumClass is not "enum type" method returns null so I think we can remove redundant method check method_exists($enumClass, 'tryFrom') because if it is enum it by default have that method if it is not enum then method returns null

So I have done those changes PR link #51282

and this is method from PR

    /**
     * Retrieve input from the request as an enum.
     *
     * @template TEnum
     *
     * @param  string  $key
     * @param  class-string<TEnum>  $enumClass
     * @return TEnum|null
     */
    public function enum($key, $enumClass)
    {
        if ($this->filled($key) && enum_exists($enumClass)) {
            return $enumClass::tryFrom($this->input($key));
        }

        return null;
    }

I think it is correct refactoring. I have also added a test for the enum() method's handling of empty value requests.

[mbabker]

The root enum class, UnitEnum, does not have a tryFrom() method. This is only part of the BackedEnum class. So technically the method_exists() check, even if it could be expressed better but probably won't due to Laravel's liberal use of duck-typing in the framework, is required. I guess technically this way one could create a non-backed enum and implement a custom tryFrom() method, but that seems like such an off edge case for PHP as a whole that there's little benefit to the framework allowing this.

Even the generic template on the method leaves the type narrowing out of its declaration, so passing any PHP class string there would be legal, so the usefulness of that is even minimal at best.

[henzeb]

It does allow quite a bit... In new software a case can be written redundant... "case Admin='Admin';" looks foolish, even when using lowercase. Maybe one day they will add tryFrom to unitEnums