[5.2] Fix environment setting

[nowak-ninja]

No description provided.

[GrahamCampbell]

Don't worry about the CS. StyleCI automatically merges the fixes after we merge PRs. Also note that you can download and apply the diff StyleCI gives instead of manually making fixes.

[nowak-ninja]

@GrahamCampbell good point, I'm kind of newbie in making PRs here :)

[GrahamCampbell]

I'm kind of newbie in making PRs here :)

No problem at all. ;)

[taylorotwell]

What does this actually do / fix?

[nowak-ninja]

@taylorotwell It fixes ability to run CLI in chosen environment based on .env.* file

[vlakoff]

Could $app->detectEnvironment() be called sooner by the user? Because this method writes over $this['env']... Also of course, it would ignore user custom detection.

[taylorotwell]

What this code does is just not obvious from reading it. Perhaps there is a better solution another way.

[vlakoff]

Ouch, that's a complicated one.

• Refs notably [5.2] Load custom .env file if it exists #11844
• @taylorotwell, about this change, are you sure Dotenv shouldn't load if config is cached? Aren't they two different things?