-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running feature tests in a separate process in PHP 8.3 fails #49593
Comments
I'm having the same issues when moving my projects over to PHP 8.3. #49237 seems like a duplicate but I think this should be revisited as it backwards breaking. |
I have the same problem. Temporary I had to disable flag |
Laravel Framework never officially supports using this flag as mentioned in the other issue and instead suggest using |
Then why does it work with php8.2? I never used flag --parallel |
When we say "it's not officially supported" that's mean that whether it is working or not it not something that we provide or guarantee support for, and any breaking to what we don't officially support are not consider as breaking changes. |
Is this lack of support listed anywhere? This feature has been working for years within Laravel and a recent update broke it. Some repos, including mine have thousands of tests that will need rethinking which the |
In the same boat!! Any solutions ? |
On the same boat!! on Laravel 10 / PHP 8.2 fails with either #[RunInSeparateProcess] or processIsolation="true" From what I see in my case seems related with tests that make use of Any ideas?? I see reference of this issue here: sebastianbergmann/phpunit#5677 Hey @siketyan, have you reached any conclusions on this? Can you shed some light on the matter? |
@adrianodias8 IIRC Laravel 11 already supports PHPUnit 11, and PHPUnit 11 has a detector of remained error handler settings; this issue should be resolved in Laravel 11. Did you tried PHPUnit 11 to see any error handler is detected after tests? If so, your code might set an error handler without removing it, not an issue of pure Laravel. I still don't know why this issue occurs on PHP >= 8.3 only. I am going to close the PR as the issue is considered as resolved in Laravel 11 or PHPUnit 11. (I am no longer in any Laravel/PHP project for now so cannot check this issue still reproducible in Laravel 11, sorry) |
Laravel Version
10.39.0
PHP Version
8.3.1
Database Driver & Version
No response
Description
Running a feature test with the
RunInSeparateProcess
attribute (or@runInSeparateProcess
annotation) on PHP 8.3 fails immediately.Steps To Reproduce
Create a feature test that uses the
RunInSeparateProcess
attribute (or@runInSeparateProcess
annotation).Run the test.
NOTE: The above does not fail on PHP 8.2 and the following unit test does not fail on PHP 8.3.
The text was updated successfully, but these errors were encountered: