[5.2] Blade push with layouts weird ordering #12808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide more unit tests to prove this fixes your issue? |
| $factory->appendSection(); | ||
| $this->assertEquals('hi', $factory->yieldContent('foo')); | ||
| $factory->stopPush(); | ||
| $this->assertEquals('hi', $factory->yieldPushContent('foo')); | ||
| } |
There was a problem hiding this comment.
Since @push uses startPush, so this tests whether the startPush, stopPush, yieldPushContent works
|
Reports of this breaking things: #12948 |
|
Ping @mark86092. |
|
@GrahamCampbell sorry, the time is my mid sleep night, I reply it ASAP when morning. See #12948 below |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified version of #12769, this time, I separate the logic of
@pushand@section. So, only the push and stack part are modified.Reason to separate push and section:
startSection. If I keep it, I have to break the structure of internal$sectionsor break the behavior ofappendSection@pushand@sectionwith same name together. i.e.is undefined. So, we can separate them.