[5.1] Fixed support for PHP 7.1 #14549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,6 +86,10 @@ public function testOpenSslEncrypterCanDecryptMcryptedData() | |||
| $this->markTestSkipped('Mcrypt module not installed'); | |||
| } | |||
|
|
|||
| if (version_compare(PHP_VERSION, '7.1') > 0) { | |||
| $this->markTestSkipped('Not compatable with PHP 7.1+'); | |||
| } | |||
There was a problem hiding this comment.
You can still install the mcrypt extension on PHP 7.1 (infact, travis has), but running it fail the tests due to the deprecation.
There was a problem hiding this comment.
Also the comparison operator should be >= 0, or you can do if (version_compare(PHP_VERSION, '7.1', '>='))
tillkruss
pushed a commit
to tillkruss/framework
that referenced
this pull request
Aug 30, 2016
* Test on PHP 7.1 * Fixed cache incrementing on php 7.1 * Skipped the legacy encrypter test on PHP 7.1+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.