-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Fixed aggregate queries #14793
Conversation
* @return float|int | ||
* @param string $function | ||
* @param array $columns | ||
* @return mixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may now become int|float
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeh, oops, Meant to put that :)
Can you describe whats going on here? |
I like that you try to do something with my earlier comments in #14781 but really doubt if we should go this way. Has there been any practical issues with |
Yeh, it'll break if you have strict types turned on and you were expecting a float instead of a string without these changes. |
Ah, in a PHP 7 context that makes sense. With |
I might have posted a comment in the wrong place. I have issues since this change with the min and max method. I am trying to get the maximum value if a date time field like |
Basically reverted this. |
No description provided.