Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Send multipart email notification #15016

Merged
merged 2 commits into from
Aug 27, 2016
Merged

Conversation

tillkruss
Copy link
Contributor

@tillkruss tillkruss commented Aug 24, 2016

It would be nice if Laravel would send a plain text alternative alongside the HTML email notifications out of the box. Reasons for that are:

  • Improves the spam score
  • Some email clients/apps still can’t handle HTML
  • Some people prefer viewing emails as plain text

Since calling php artisan vendor:publish is necessary anyhow to add the new plain text template file, I also went ahead and changed the resource directory structure from:

notifications/email.blade.php

To:

notifications/email/html.blade.php
notifications/email/text.blade.php

If that's too much of a breaking change, we could do this:

notifications/email.blade.php
notifications/email-plain.blade.php

Feedback appreciated 😀

@tillkruss tillkruss changed the title Send multipart email notification [5.3] Send multipart email notification Aug 24, 2016
@taylorotwell
Copy link
Member

I would go with the non-breaking change method.

@tillkruss tillkruss force-pushed the text-emails branch 2 times, most recently from be4cd4b to bf4d338 Compare August 26, 2016 18:05
@tillkruss
Copy link
Contributor Author

Done.

php artisan vendor:publish is still necessary, but users who customized their email.blade.php file won't have to move it.

@taylorotwell taylorotwell merged commit 8a0879c into laravel:5.3 Aug 27, 2016
@taylorotwell
Copy link
Member

Thanks. Can you send a docs PR?

@tillkruss tillkruss deleted the text-emails branch August 27, 2016 14:02
@tillkruss
Copy link
Contributor Author

Sure.

laravel/docs#2581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants