Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Validator explodeRules param type in docblock #15838

Merged
merged 1 commit into from
Oct 10, 2016
Merged

[5.3] Validator explodeRules param type in docblock #15838

merged 1 commit into from
Oct 10, 2016

Conversation

antonkomarev
Copy link
Contributor

If string will be bypassed somehow an exception will be raised:

Invalid argument supplied for foreach()

@GrahamCampbell GrahamCampbell changed the title Validator explodeRules param type in docblock [5.3] Validator explodeRules param type in docblock Oct 10, 2016
@GrahamCampbell
Copy link
Member

If string will be bypassed somehow an exception will be raised

That's actually not an "Exception". :)

@taylorotwell taylorotwell merged commit 2fee918 into laravel:5.3 Oct 10, 2016
@antonkomarev
Copy link
Contributor Author

@GrahamCampbell You are right :} I've refactored exceptions in my code all day long and right now all things looks like an exceptions around me...

@antonkomarev antonkomarev deleted the hotfix/validator-rules-param-type branch October 10, 2016 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonkomarev @GrahamCampbell @taylorotwell