[5.1] Fix improper use of mb_substr() #16081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10894.
Because
strpos($path, '?')
is single-byte, the subsequentsubstr()
have to be single-byte as well.url('ééé/ààà?ùùù', 'extra');
http://example.org/ééé/ààà/extra?ùùù
– expectedhttp://example.org/ééé/ààà?ùùù/extra
– resulturl('ééé?ààà?ùùù', 'extra');
http://example.org/ééé/extra?ààà?ùùù
– expectedhttp://example.org/ééé?àà/extraà?ùùù
– resultping @rkgrep :)