Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Remove hard coded (English) prose from scheduled task email subject when description is defined #16790

Conversation

stevenmaguire
Copy link
Contributor

I feel as if the developer should be in control of the email subject that is used when sending the scheduled job output via email. Currently, the default behavior will always include the text "Scheduled Job Output" in the email subject. I previously submitted a separate PR that provided a less invasive solution for this desired behavior and it was shot down without conversation because "You can already customize the subject by setting a description."

So, I humbly submit this follow-up PR which changes existing functionality to grant framework consumers the ability to set the entire email subject to any value they desire, including any non-english value because sometimes people use Laravel to communicate with people whose primary language is not english.

I am happy to port the tests over from the previous PR as they would be appropriate here, but I am not going to waste my time if this is going to be arbitrarily shot down without rational discourse.

@taylorotwell taylorotwell merged commit 454c8e2 into laravel:5.3 Dec 14, 2016
@stevenmaguire
Copy link
Contributor Author

Thanks @taylorotwell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants