[5.3] Remove hard coded (English) prose from scheduled task email subject when description is defined #16790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel as if the developer should be in control of the email subject that is used when sending the scheduled job output via email. Currently, the default behavior will always include the text "Scheduled Job Output" in the email subject. I previously submitted a separate PR that provided a less invasive solution for this desired behavior and it was shot down without conversation because "You can already customize the subject by setting a description."
So, I humbly submit this follow-up PR which changes existing functionality to grant framework consumers the ability to set the entire email subject to any value they desire, including any non-english value because sometimes people use Laravel to communicate with people whose primary language is not english.
I am happy to port the tests over from the previous PR as they would be appropriate here, but I am not going to waste my time if this is going to be arbitrarily shot down without rational discourse.