Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Revert dynamic eval call #17360

Merged
merged 3 commits into from
Jan 17, 2017
Merged

[5.5] Revert dynamic eval call #17360

merged 3 commits into from
Jan 17, 2017

Conversation

GrahamCampbell
Copy link
Member

Since Laravel 5.5 is PHP 7.0+, then functions of this name are fine.

@taylorotwell
Copy link
Member

Isn't the __call still needed to fallback to ->command()?

@GrahamCampbell
Copy link
Member Author

Hmm, well, I just directly reverted the two commits.

@GrahamCampbell
Copy link
Member Author

Actually, no, that method is not required, because the __call method is already defined on the parent class. I'll update the 5.4 implementation to call the parent method to avoid this confusion.

@GrahamCampbell
Copy link
Member Author

#17366

@taylorotwell taylorotwell merged commit 05651c4 into master Jan 17, 2017
@GrahamCampbell GrahamCampbell deleted the revert branch January 17, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants