Change the BladeCompiler::if type-hint to callable like directive #20025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Blade::if()` method accepts `callable` to allow more flexibility in how you call the conditional directive. This type-hint matches the `Blade::directive()` type-hint.
|
This might be the smallest PR ever 😄 |
laurencei
reviewed
Jul 12, 2017
| @@ -358,7 +358,7 @@ public function getExtensions() | |||
| * @param \Closure $callback | |||
There was a problem hiding this comment.
would need to make this @param callable $callback
There was a problem hiding this comment.
@laurencei nice catch, thanks
|
It was also pointed out to me that \Closure::fromCallable() could be used to convert a callable, but I think its better to make them consistent. Thoughts? |
paulredmond
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I proposed a feature in laravel/ideas#682 and noticed that the
Blade::if()signature doesn't allowcallablelikeBlade::directive()does.I've updated the
Blade::if()method to acallabletype-hint to allow more flexibility in how you define a conditional directive.