[5.5] Better BadMethodCallException message when dealing with Eloquent
#20196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think even experienced developers can benefit from this |
lucasmichot
reviewed
Jul 20, 2017
| @@ -453,6 +453,28 @@ public function testFromDateTime() | |||
| $this->assertEquals('2015-04-17 22:59:01', $model->fromDateTime($value)); | |||
| } | |||
|
|
|||
| public function testBadMethodCallException() | |||
There was a problem hiding this comment.
Use this docblock instead:
/**
* @expectedException \BadMethodCallException
* @expectedExceptionMessage Call to undefined method Illuminate\Tests\Database\EloquentModelStub::badMethod()
*/| return $this->newQuery()->$method(...$parameters); | ||
| try { | ||
| return $this->newQuery()->$method(...$parameters); | ||
| } catch (\BadMethodCallException $e) { |
There was a problem hiding this comment.
Import \BadMethodCallException
|
@ThibaudDauce I was playing around with this idea earlier last week. Your implementation is brilliant. Way to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think for newcomers in Laravel and PHP beginners, the message "Call to undefined method Illuminate\Database\Query\Builder::badMethod()" could be confusing.
Wrapping the call to the builder and throwing a new
BadMethodCallExceptionwith the correct message ("Call to undefined method App\User::badMethod()") could be helpful.I chose to assert the entire string in the test but I can change it to just asserting that
Illuminate\Tests\Database\EloquentModelStubis contains in the message.