Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Added setConnection() to Model save method. #20466

Merged
merged 1 commit into from
Aug 8, 2017
Merged

[5.5] Added setConnection() to Model save method. #20466

merged 1 commit into from
Aug 8, 2017

Conversation

djh101
Copy link

@djh101 djh101 commented Aug 7, 2017

Repull of #20444 to master branch.

@tillkruss tillkruss changed the title Added setConnection() to Model save method. [5.5] Added setConnection() to Model save method. Aug 7, 2017
@taylorotwell taylorotwell merged commit b0ff2a6 into laravel:master Aug 8, 2017
@deleugpn
Copy link
Contributor

deleugpn commented Aug 8, 2017

Won't this reproduce the same problem of #18545 when saving related objects into different databases? @Xethron @themsaid

@themsaid
Copy link
Member

themsaid commented Aug 8, 2017

@deleugpn how?

@djh101 djh101 deleted the master branch August 10, 2017 03:02
@djh101 djh101 mentioned this pull request Aug 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djh101 @deleugpn @themsaid @taylorotwell