[5.5] setModel parameter should be the model name #20896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all other cases throughout the framework where setModel is called on ModelNotFoundException, the string name of the model is passed. Here, in ImplicitRouteBinding, a ReflectionClass object is passed. Before: When calling 'getModel' on the exception object, a ReflectionClass object will be returned. After: $exception->getModel will return the string name of the model, just as it does elsewhere in the framework.
devcircus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #20888
Details:
In all other cases throughout the framework where setModel is called on ModelNotFoundException, the string name of the model is passed. Here, in ImplicitRouteBinding, a ReflectionClass object is passed.
Before:
When calling 'getModel' on the exception object, a ReflectionClass object will be returned.
After:
$exception->getModel will return the string name of the model, just as it does elsewhere in the framework.