[5.5] Change order of checks in JsonResponse #21136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #21079 if you have a class implementing both
Arrayable
andJsonable
interface and have different returns for itstoArray()
andtoJson()
methods, theJsonResponse
will prefer thetoArray()
return overtoJson()
return.Before #17875, as the check was done inside the
Response
, theJsonable
implementation was checked before theArrayable
. So if we didn't explicitly returned aJsonResponse
this wasn't a problem at all.But after #17875 the
Router
checks the response type and creates a newJsonResponse
which have a different logic as described above.This PR brings the type-checking logic in
JsonResponse
to behave more likely asResponse
(check first forJsonable
then forArrayable
).Please refer to #21079 for an example with different implementations of
toArray()
andtoJson()