Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] setGlobalTo Mailer method should reset CC and BCC #21137

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

ilyadrv
Copy link
Contributor

@ilyadrv ilyadrv commented Sep 12, 2017

setGlobalTo Mailer method should reset CC and BCC. Otherwise, this just duplicates emails.

@deleugpn
Copy link
Contributor

Breaking change?

@taylorotwell
Copy link
Member

Hmm, to me this could be considered a bug fix.

@taylorotwell taylorotwell merged commit 5167414 into laravel:5.5 Sep 12, 2017
@ilyadrv
Copy link
Contributor Author

ilyadrv commented Sep 12, 2017

Probably not breaking, but if use config('mail.to') you receive all emails twice. Probably most of the people use this on dev so it should be just annoying.

@GrahamCampbell GrahamCampbell changed the title setGlobalTo Mailer method should reset CC and BCC [5.5] setGlobalTo Mailer method should reset CC and BCC Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants