[6.x] Convert call_user_func where appropriate to native calls #29932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similarly, one should be careful not to accept blind |
crynobone
reviewed
Sep 11, 2019
| $stateAttributes, | ||
| $this->faker, $attributes | ||
| ); | ||
| return $stateAttributes($this->faker, $attributes); |
There was a problem hiding this comment.
Here it's checking for is_callable(), if you give [$object, 'bar'] it going to return true, but AFAIK it not possible to do [$object, 'bar'](...)
Tested, seem to work.
There was a problem hiding this comment.
Yeh, you can call callables like that. The two cases I didn't convert are ones with assignments to the variable holding the callable within the call_user_func parameters, and callables which were properties of classes.
voku
added a commit
to voku/framework
that referenced
this pull request
Mar 2, 2020
- fix phpdocs - add static (for anonymous functions, less for for PHP and for the IDE, because $this is not allowed) - use some more modern phpdocs (e.g. array => Model[]) - use php7 features like "array-unpacking" - replace "call_user_func" (laravel#29932 <- the test did not fail, but maybe I missed something here) - use "array_values()" only if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that it is not always possible or sensible to convert every instance of
call_user_func, so I haven't - I have changed the ones where it is safe to do so, and doesn't make the syntax worse. The advantage to avoidingcall_user_funcis a performance speed up, and easy reading.Be careful if someone else sends a follow PR converting the rest, because the implementation will likely be incorrect. For example, in the eloquent query builder, changing the
call_user_funcs on the$querys will actually change the order of execution and be incorrect!