Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Make it possible to disable to disable encryption via 0/false #29985

Merged
merged 2 commits into from Sep 13, 2019

Conversation

@lsmith77
Copy link
Contributor

commented Sep 13, 2019

it is not possible to set an env var to null, so its otherwise impossible to disable encryption via an env variable

this will for example make it possible to provide out of the box support for Laravel emailing on platform.sh via their bridge:
https://github.com/platformsh/laravel-bridge/blob/master/platformsh-laravel-env.php#L155

lsmith77 and others added 2 commits Sep 13, 2019
it is not possible to set an env var to `null`, so its otherwise impossible to disable encryption via an env variable
@taylorotwell taylorotwell merged commit b57d6bb into laravel:6.x Sep 13, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/styleci/pr The analysis has passed
Details
@lsmith77 lsmith77 deleted the lsmith77:patch-1 branch Sep 13, 2019
@lsmith77

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

now that was fast :)

BTW I wonder if there are other places within laravel that should be reviewed for this type of issue.

@lsmith77 lsmith77 referenced this pull request Sep 13, 2019
@GrahamCampbell GrahamCampbell changed the title make it possible to disable to disable encryption via 0/false [6.x] Make it possible to disable to disable encryption via 0/false Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.