[6.x] Allow adding command arguments and options with objects #29987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow the end user to define arguments and options in artisan commands by instantiating objects (more specifically,
InputArgument
andInputOption
objects) instead of using "plain" arrays. The benefit of this is that you won't have to refer back to the documentation to see the order in which the array should be constructed. Instead, you can look at the constructor of theInputArgument
/InputOption
class.Before:
After:
It should be noted that the "old" way still works, this is simply an extra way of doing it.
I've also added a (hopefully useful) test, though I couldn't figure out how to properly "mock" the
$application
that should be given to the command via->setLaravel()
. I'd appreciate some pointers about how I should go about doing this without whipping up a fullApplication
object.