[6.x] Improved AuthServiceProvider::registerEventRebindHandler() #30105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duxthefux
force-pushed
the
improve-event-rebind-handler
branch
2 times, most recently
from
be1fc94
to
89ad1c1
Compare
driesvints
changed the title
|
@duxthefux I fixed the build on the 6.x branch. Can you rebase? The build will pass then. |
* as Auth::guard() not only checks for an existing guard but also initializes a new guard in case ob absence. This can lead to side-effects when overbinding 'events' in another service provider
duxthefux
force-pushed
the
improve-event-rebind-handler
branch
from
89ad1c1
to
b28ef65
Compare
|
@driesvints Thx a lot! I force pushed. Looks good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initializes a new guard in case ob absence. This can lead to side-effects
when overbinding 'events' in another service provider
eventsif overbind with a library like https://github.com/fntneves/laravel-transactional-events. Then it leads to actually always creating a guard although it's might not needed.Please note that this is my first MR and I'm happy to hear feedback and adjust it.
Thanks a lot!