Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[6.x] Improved AuthServiceProvider::registerEventRebindHandler() #30105
Please note that this is my first MR and I'm happy to hear feedback and adjust it.
Thanks a lot!
* as Auth::guard() not only checks for an existing guard but also initializes a new guard in case ob absence. This can lead to side-effects when overbinding 'events' in another service provider
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.