Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add retryUntil to SendQueueNotifications #30141

Conversation

@bastien-phi
Copy link
Contributor

commented Sep 30, 2019

This PR adds ability to define the retryUntil or timeoutAt in Notification and to be passed to SendQueueNotifications.

I think this feature is useful if we want to control how long we try to send the notification without thinking about how many times we will try to send it, for example when the notification is sent through RateLimited and we want it to be sent no matter how much times we tried to.

@bastien-phi bastien-phi force-pushed the bastien-phi:add-retry-until-to-send-queue-notifications branch from 500f98e to 935f1bc Sep 30, 2019
@taylorotwell taylorotwell merged commit 370ee34 into laravel:6.x Oct 1, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ahinkle

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

Hey there, would you be able to submit a PR to the docs?

i-bajrai added a commit to i-bajrai/framework that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.