[6.x] Fixed shouldQueue() check for bound event listeners #30378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have an Event Listener that implements the ShouldQueue interface.
Laravel provides a perfect way to handle should handler be queued or not with
shouldQueue
method.If the listener has
shouldQueue
method and it returnsfalse
handler won't be queued.But if we bind Listener via Service container and implement
shouldQueue
in the child classshouldQueue
method won't be triggered if parent class doesn't haveshouldQueue
method.This PR fixes this issue by creating an instance before
method_exists
check.